Allows Fn::GetAtt with Lambda DLQ-onError #5139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arn references for SQS queues are now available using: ``` Fn::GetAtt: - Queue - Arn ```
|
Does this solve the race condition mentioned in the doc? https://serverless.com/framework/docs/providers/aws/guide/functions#dlq-with-sqs |
|
I'm not sure. I haven't experienced the race condition myself with this patch and I have done a couple of fresh re-deployments. |
|
Can we expect any review in near future? |
|
Can we expect any review in near future please !!! |
pmuens
approved these changes
Jan 28, 2019
There was a problem hiding this comment.
Thanks for working on this @martinjlowm 👍
Just tested it with the following configuration:
service: test # NOTE: update this with your service name
provider:
name: aws
runtime: nodejs8.10
iamRoleStatements:
- Effect: Allow
Action:
- sqs:SendMessage
- sqs:DeleteMessage
- sqs:ReceiveMessage
Resource: arn:aws:sqs:*:*:SampleQueue
functions:
hello:
handler: handler.hello
onError:
Fn::GetAtt:
- MyQueue
- Arn
resources:
Resources:
MyQueue:
Type: AWS::SQS::Queue
Properties:
QueueName: SampleQueueWorks like expected 👍
Just pushed another minor doc update. Will merge once the build is green 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Arn references for SQS queues are now available using:
How did you implement it:
According to https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-sqs-queues.html#aws-properties-sqs-queues-ref an SQS reference returns its URL which is not sufficient for Lambda DLQ config which requires an ARN.
isArnRefOrImportValueis renamed toisArnRefGetAttOrImportValueand extended to also look forFn::GetAtt.How can we verify it:
Write a minimal Serverless setup that mimics that of the new test:
'should create necessary resources if a Fn::GetAtt is provided'.Todos:
Is this ready for review?: Yes
Is it a breaking change?: NO